feat: Implement stateful retry and resumable stream logic for TopicMessageQuery#2171
Merged
manishdait merged 10 commits intoJun 2, 2026
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces fixes for flaky
TopicMessageQuerye2e tests by implementing retry logic and error handling.Changes Made:
SubscriptionStateto track last_message and count. on retry, the query resumes fromlast_message.consensusTimestamp + 1nsto prevent message loss or duplication._should_retry logicto identify retryable gRPC errors (e.g.,UNAVAILABLE,RESOURCE_EXHAUSTED) and specificRST_STREAMinternal errors.SubscriptionHandleto safely manage gRPC call cancellation across threads.Related issue(s):
Fixes #1796
Notes for reviewer:
Checklist